Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support non-x86 build #882

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Nov 29, 2022

  1. Upgrade to ckb-vm 0.22.0.
  2. Use a separate crate ckb-vm-aot to enable the AOT feature on x86.
  3. Use the trace machine in non-x86 environments.
  4. Copy files from https://github.com/nervosnetwork/ckb-sdk-rust - We met a lot of troubles when upgrading the ckb-sdk crate. It contains too many dependencies that may conflict with Godwoken's dependencies, and we want to make the dependencies minimal, so we copy what we need from the repo.

@blckngm
Copy link
Contributor

blckngm commented Nov 29, 2022

Do we want to check this in CI? Don't know how ready the github hosted M1 runners are, but we can always cross check for aarch64-unknown-linux-gnu.

@jjyr jjyr requested review from zeroqn, blckngm, keroro520, a team and magicalne November 29, 2022 17:50
@jjyr
Copy link
Collaborator Author

jjyr commented Nov 29, 2022

Do we want to check this in CI? Don't know how ready the github hosted M1 runners are, but we can always cross check for aarch64-unknown-linux-gnu.

I will make the change of CI in another PR. It is painful to get it run correctly...

keroro520
keroro520 previously approved these changes Nov 30, 2022
Copy link
Contributor

@keroro520 keroro520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/tools/Cargo.toml Outdated Show resolved Hide resolved
@jjyr jjyr requested review from blckngm and keroro520 November 30, 2022 07:51
blckngm
blckngm previously approved these changes Nov 30, 2022
keroro520
keroro520 previously approved these changes Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants