Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support CKB built-in indexer #907

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Dec 14, 2022

If a CKB indexer RPC url is explicitly specified, we assume that we are
connecting to a standalone indexer (i.e. we use get_tip).

Otherwise we just use CKB RPC url and assume that we are connecting to
CKB builtin indexer (i.e. we use get_indexer_tip).

BREAKING CHANGE:

There are some small breaking changes for gw-tools: if the ckb-indexer-rpc arg is not specified, we default to using CKB built-in indexer instead of "127.0.0.1:8116".

If a CKB indexer RPC url is explicitly specified, we assume that we are
connecting to a standalone indexer (i.e. we use `get_tip`).

Otherwise we just use CKB RPC url and assume that we are connecting to
CKB builtin indexer (i.e. we use `get_indexer_tip`).
@Flouse Flouse requested review from jjyr and zeroqn December 15, 2022 09:09
@jjyr jjyr requested review from magicalne and a team December 16, 2022 14:57
@jjyr jjyr merged commit 79e4763 into godwokenrises:develop Dec 19, 2022
@jjyr jjyr mentioned this pull request Dec 19, 2022
Flouse added a commit to Flouse/godwoken-info that referenced this pull request Jan 1, 2023
Flouse added a commit to godwokenrises/godwoken-info that referenced this pull request Jan 1, 2023
@blckngm blckngm deleted the support-built-in-indexer branch March 14, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants