Skip to content

Commit

Permalink
chore: change description to require forking the repository
Browse files Browse the repository at this point in the history
  • Loading branch information
alexciesielski committed Jul 28, 2022
1 parent 4f6fb7c commit 79bbc66
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Prerequisites

**Important**: Please **fork the repository before cloning**. Cloning this repository directly will result in an error when pushing your changes if you're not authorized with our organization.

- Node 16
- Angular CLI

Expand Down
4 changes: 3 additions & 1 deletion README_ANGULAR.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Hello and thanks for your interest in the "Angular developer" position here @ Y4

If you haven't yet please first read the [main readme](README.md) to setup the working environment and get the app up and running.

**Important**: Please **fork the repository before cloning**.

## Technical details

rxjs `BehaviorSubject`s are being used for state management.
Expand All @@ -14,7 +16,6 @@ Since that API does not support mutating calls like PUT or DELETE we are simulat

## Expectations

- Please checkout a new branch at `angular/{your-name} and commit your changes there.
- Please implement at least two of the below tasks.
- Please do not forget (happy path) unit tests.
- Please keep in mind that code quality and cleanliness, ie. adherence to best practices will be evaluated.
Expand All @@ -34,3 +35,4 @@ Since that API does not support mutating calls like PUT or DELETE we are simulat
- New code is covered by unit tests (happy path)

Once you are ready please open a pull-request.
Remember that this only works from **forked** repositories.
5 changes: 4 additions & 1 deletion README_E2E.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Hello and thanks for your interest in the "automated test developer" position he

If you haven't yet please first read the [main readme](README.md) to setup the working environment and get the app up and running.

**Important**: Please **fork the repository before cloning**.

As your task for the role you will implement automated tests against our demo application.

As described in the [main readme](README.md) it is a simple product catalog with editing capabilities that is "secured" by a login form.
Expand Down Expand Up @@ -35,4 +37,5 @@ Write automated tests (using Playwright) to test that the application
- Running `npm run e2e` succeeds
- The CI pipeline is green

Once you are ready please either open a pull-request or send a link to your Github branch where the solution is implemented back to the recruiter.
Once you are ready please open a pull-request.
Remember that this only works from **forked** repositories.

0 comments on commit 79bbc66

Please sign in to comment.