-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 (fiberi18n): Fix request concurrency errors #723
Conversation
pls update the go.mod version to /v2 like this |
@Skyenought Can you add a test for |
@Skyenought you may need to run |
May as well also add |
@gaby After I run So I don't know what went wrong. |
Try this, delete your go.sum file then run |
Useless, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 1.18 from test
It doesn't look like it's working. |
I'm not sure what's going on, the CI for Lets try this, make your go.mod the following the run module github.com/gofiber/contrib/fiberi18n/v2
go 1.19
require (
github.com/gofiber/fiber/v2 v2.49.0
github.com/nicksnyder/go-i18n/v2 v2.2.1
) |
6e28e91
to
77c14f1
Compare
|
Finally solved the |
Do we really need all thos |
i don't know, it just test.Maybe a PR is needed to modify the github action |
d4f0dd5
to
0db09d7
Compare
@Skyenought Can you update your branch with master. The go.mod changes were done there to avoid release issues |
i did the update |
# Conflicts: # fiberi18n/i18n.go
fix #721
MustGetMessage(param interface{}) (string, error)
,GetMessage
->MustLocalize
,Localize
, Similar github.com/nicksnyder/go-i18n/v2