Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Bug]: dictpool is deprecated #2209

Closed
3 tasks done
leonklingele opened this issue Nov 12, 2022 · 4 comments · Fixed by #2540
Closed
3 tasks done

🐛 [Bug]: dictpool is deprecated #2209

leonklingele opened this issue Nov 12, 2022 · 4 comments · Fixed by #2540
Labels
☢️ Bug

Comments

@leonklingele
Copy link
Member

Bug Description

https://github.com/savsgio/dictpool was deprecated a couple of weeks ago. A copy of it is tracked here: https://github.com/gofiber/fiber/tree/e388e0edb3c6d4bdbfa41e8d533e1f4bd734404d/internal/dictpool

How to Reproduce

Expected Behavior

Fiber Version

latest

Code Snippet (optional)

No response

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my problem prior to opening this one.
  • I understand that improperly formatted bug reports may be closed without explanation.
@efectn
Copy link
Member

efectn commented Nov 12, 2022

Closed by 73b43cc

@efectn efectn closed this as completed Nov 12, 2022
@leonklingele
Copy link
Member Author

Can this be backported to v2 as well?

@leonklingele
Copy link
Member Author

@efectn any news on this? :)

@efectn
Copy link
Member

efectn commented May 15, 2023

Can this be backported to v2 as well?

Sounds OK to me

andre-dasilva added a commit to andre-dasilva/fiber that referenced this issue Jul 10, 2023
@andre-dasilva
Completely remove dictpool
9f8db17 
Looks like issue:
gofiber#2209
Was not complete. So here dictpool is completely gone
@andre-dasilva andre-dasilva mentioned this issue Jul 10, 2023
Merged
11 tasks
ReneWerner87 pushed a commit that referenced this issue Jul 11, 2023
@andre-dasilva
🩹 Fix: dictpool is not completely gone (#2540)
58270e2 
* Completely remove dictpool

Looks like issue:
#2209
Was not complete. So here dictpool is completely gone

* Fix linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹 Fix: dictpool is not completely gone andre-dasilva/fiber
2 participants
@leonklingele @efectn