Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix onListen hooks when they are used with prefork mode #2504

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

efectn
Copy link
Member

@efectn efectn commented Jun 9, 2023

Description

Hooks doesn't work properly in prefork mode because of we run them all in child processes. This PR allows them to be used on child or master processes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

🐛 bug: fix onListen hooks when they are used with prefork mode
@ReneWerner87 ReneWerner87 merged commit d4938da into master Jun 9, 2023
@efectn efectn deleted the fix-onlisten-prefork branch June 9, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants