Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint to v1.56.1 #2842

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Bump golangci-lint to v1.56.1 #2842

merged 12 commits into from
Feb 13, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Feb 10, 2024

  • Bump golangci-lint to v1.56.1

@ReneWerner87
Copy link
Member

@gaby
image

hm and this
image
is it a flaky test?

@gaby
Copy link
Member Author

gaby commented Feb 10, 2024

@ReneWerner87 golangci-lint changed quite a few things in v1.56.0, I plan on fixing those. The test failing is a different issue.

@nickajacks1
Copy link
Member

is it a flaky test?
Yes, Session is one of the intermittently failing tests.

And just to say it out loud, 1.56 added https://github.com/jjti/go-spancheck which has to do with opentelemetry, so we don't need it right now.

nickajacks1
nickajacks1 reviewed Feb 10, 2024
View reviewed changes
app_test.go Outdated Show resolved Hide resolved
@gaby
Copy link
Member Author

gaby commented Feb 11, 2024

This was way more changes that I thought. For some reason golangci-lint stops checking after N amount of errors. So i had to constantly be running it. Turns out there was over +100 warnings

gaby
gaby commented Feb 11, 2024
View reviewed changes
.golangci.yml Show resolved Hide resolved
nickajacks1
nickajacks1 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@nickajacks1 nickajacks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, thanks for fixing all of these

middleware/adaptor/adaptor.go Outdated Show resolved Hide resolved
@gaby gaby requested a review from nickajacks1 February 11, 2024 20:43
@gaby gaby requested a review from a team as a code owner February 11, 2024 20:48
@gaby gaby mentioned this pull request Feb 11, 2024
Merged
3 tasks
@ReneWerner87 ReneWerner87 merged commit 9dabf96 into main Feb 13, 2024
17 checks passed
@ReneWerner87 ReneWerner87 deleted the bump-cilint branch February 13, 2024 07:23
@gaby gaby mentioned this pull request Mar 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickajacks1 nickajacks1 nickajacks1 approved these changes

@efectn efectn efectn approved these changes

@sixcolors sixcolors sixcolors approved these changes

@ReneWerner87 ReneWerner87 Awaiting requested review from ReneWerner87

@Fenny Fenny Awaiting requested review from Fenny

Assignees
No one assigned
Labels
🧹 Updates v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaby @ReneWerner87 @nickajacks1 @sixcolors @efectn