Skip to content

Commit

Permalink
Merge pull request #87 from gofiber/lint-update
Browse files Browse the repository at this point in the history
Bump golangci-lint to v1.59.1
  • Loading branch information
ReneWerner87 authored Jul 2, 2024
2 parents f0ebb96 + f7a37a7 commit 5bbcf73
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ jobs:
uses: golangci/golangci-lint-action@v5
with:
# NOTE: Keep this in sync with the version from .golangci.yml
version: v1.57.1
version: v1.59.1
9 changes: 3 additions & 6 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# v1.2.0. Created based on golangci-lint v1.57.1
# v1.2.0. Created based on golangci-lint v1.59.1

run:
timeout: 5m
Expand Down Expand Up @@ -238,11 +238,9 @@ linters-settings:
time-layout: false # TODO: Set to true
crypto-hash: true
default-rpc-path: true
os-dev-null: true
sql-isolation-level: true
tls-signature-scheme: true
constant-kind: true
syslog-priority: true

wrapcheck:
ignorePackageGlobs:
Expand All @@ -258,7 +256,7 @@ issues:
- internal # TODO: Do not ignore interal packages
exclude-rules:
- linters:
- goerr113
- err113
text: 'do not define dynamic errors, use wrapped static errors instead*'
- path: log/.*\.go
linters:
Expand Down Expand Up @@ -288,7 +286,6 @@ linters:
- errchkjson
- errname
- errorlint
- execinquery
- exhaustive
# - exhaustivestruct
# - exhaustruct
Expand All @@ -308,7 +305,7 @@ linters:
# - gocyclo
# - godot
# - godox
- goerr113
- err113
- gofmt
- gofumpt
# - goheader
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ format:
## lint: 🚨 Run lint checks
.PHONY: lint
lint:
go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.1 run ./...
go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1 run ./...

## test: 🚦 Execute all tests
.PHONY: test
Expand Down

1 comment on commit 5bbcf73

@ReneWerner87
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5bbcf73 Previous: f0ebb96 Ratio
Benchmark_StatusMessage/fiber 0.6207 ns/op 0 B/op 0 allocs/op 0.31 ns/op 0 B/op 0 allocs/op 2.00
Benchmark_StatusMessage/fiber - ns/op 0.6207 ns/op 0.31 ns/op 2.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.