Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes induction with file uploads #569

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Completes induction with file uploads #569

merged 6 commits into from
Nov 5, 2021

Conversation

sparkplug0025
Copy link
Collaborator

@sparkplug0025 sparkplug0025 commented Oct 11, 2021 •
edited
Loading

  • Adds a complete induction test using our ephemeral chain.
  • Removes the unnecessary Box E2E test since we now have a full environment on our ephemeral chain:
    • testing a real chain with contracts
    • testing a real box
    • testing a real webapp
    • hence, renamed from WebApp E2E Tests to simply E2E Tests

Base automatically changed from sparkplug0025/fix-softkey-transact to main October 15, 2021 13:05
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from 0f1542c to de28738 Compare November 2, 2021 13:17
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from de28738 to 7b200ea Compare November 2, 2021 13:26
@sparkplug0025 sparkplug0025 changed the base branch from main to sparkplug0025/ship-ci November 2, 2021 13:26
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from 624dcaa to d2c71f3 Compare November 2, 2021 14:35
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from d2c71f3 to b98428b Compare November 2, 2021 14:39
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from b98428b to 6ef6c9c Compare November 3, 2021 01:27
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from 6ef6c9c to f3a9d15 Compare November 3, 2021 01:47
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from f3a9d15 to d8ce05b Compare November 3, 2021 01:53
@sparkplug0025 sparkplug0025 marked this pull request as ready for review November 3, 2021 01:57
Base automatically changed from sparkplug0025/ship-ci to main November 4, 2021 02:50
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/more-e2e-tests branch from d8ce05b to 9942ffe Compare November 4, 2021 03:02
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests November 5, 2021 13:07 Inactive
brandonfancher
brandonfancher approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@brandonfancher brandonfancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@brandonfancher brandonfancher merged commit 918b53c into main Nov 5, 2021
@brandonfancher brandonfancher deleted the sparkplug0025/more-e2e-tests branch November 5, 2021 18:32
@brandonfancher brandonfancher mentioned this pull request Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonfancher brandonfancher brandonfancher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparkplug0025 @brandonfancher