Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AtomicHub NFTs queries to Microchain #581

Merged
merged 6 commits into from
Oct 28, 2021

Conversation

sparkplug0025
Copy link
Collaborator

@sparkplug0025 sparkplug0025 commented Oct 18, 2021

  • Tracks atomic hub contracts to populate nfts data for eden members
  • Adds nfts queries on the MemberConnection:
    • nfts: nfts represented by the member
    • collectedNfts: nfts collecetd by the member

Unfortunately we can't track auctionbid because it needs to watch the whole atomic asset bid and auctions since it does not notify eden smart contract.

Still we can derive the member nfts collections!

@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 18, 2021 01:04 Inactive
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 18, 2021 02:18 Inactive
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 19, 2021 13:39 Inactive
@sparkplug0025 sparkplug0025 marked this pull request as ready for review October 19, 2021 14:21
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 19, 2021 14:48 Inactive
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 19, 2021 22:42 Inactive
@sparkplug0025 sparkplug0025 force-pushed the sparkplug0025/nfts-queries branch from f64519c to a1c48a6 Compare October 27, 2021 00:15
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 27, 2021 00:20 Inactive
@sparkplug0025 sparkplug0025 temporarily deployed to e2e_tests October 27, 2021 00:36 Inactive
@brandonfancher
Copy link
Collaborator

We currently show in the UI when an NFT in a member's collection is up for sale. For this, we rely on the saleId. Is that something we can include also, or no?

@tbfleming
Copy link
Member

We currently show in the UI when an NFT in a member's collection is up for sale

atomicmarket doesn't notify the eden contract when this happens, so we can't track it without having an explosively-sized dfuse stream.

@sparkplug0025 sparkplug0025 merged commit eb9568f into main Oct 28, 2021
@sparkplug0025 sparkplug0025 deleted the sparkplug0025/nfts-queries branch October 28, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants