Chainmail fixes and maintenance #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brandonfancher
commented
Dec 2, 2024
•
brandonfancher
commented
- Update login to work with latest account-related changes
- Fix broken link control in markdown editor after recent dependency updates
- Dark mode style/color fixes in editor
- Investigate and resolve issues querying messages: Awaiting merge of Make C++ accept the rust schema for TimePointSec. #942
- CSS overflow issue for editor text/contents in modal
cool-ant
approved these changes
Dec 5, 2024
| @@ -33,6 +26,11 @@ import { | |||
|
|
|||
| // import { MathBlock, MermaidDiagram } from "./editor"; | |||
| // import { MathBlock } from "./editor"; | |||
There was a problem hiding this comment.
I assume all these commented imported can be deleted? Couple commented lines below as well
There was a problem hiding this comment.
They can be, but I'm keeping them around now for reimplementation of future editor features/markdown stuff.
James-Mart
added
the
System app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.