-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve package template #958
Open
James-Mart
wants to merge
17
commits into
main
Choose a base branch
from
improve-package-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
James-Mart
commented
Dec 12, 2024
- Adds prompts to template generation
- psibase version
- description
- Adds name validation
- name doesn't contain numbers (it messes up the wit naming requirements)
- name <= 12 characters (makes it much more likely the account name will successfully roundtrip)
- Adds default tasks.json to generated app. If new app is opened as a new workspace in vscode, you will see UI buttons for "Build UI" and "Build package"
- Separates query service into separate service
- Adds query for historical event emission
- Add service unit test (in separate file)
- Adds a default readme for the generated app
- Add missing dependency on Sites package (caused boot to fail if package was used at boot)
- Generates app into a directory named "MyApp" (upper camel case) instead of "my-app" to match existing app naming conventions
- Uses split wit file convention (world.wit, impl.wit) to match existing wit conventions and make imports simpler
…prove-package-template
…ooting with generated packages
…le error highlights
This PR seems to replace/improve on the |
I think it does, and github is getting confused for some reason. I see renames when I examine it in git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.