Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package template #958

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Improve package template #958

wants to merge 17 commits into from

Conversation

James-Mart
Copy link
Member

  • Adds prompts to template generation
    • psibase version
    • description
  • Adds name validation
    • name doesn't contain numbers (it messes up the wit naming requirements)
    • name <= 12 characters (makes it much more likely the account name will successfully roundtrip)
  • Adds default tasks.json to generated app. If new app is opened as a new workspace in vscode, you will see UI buttons for "Build UI" and "Build package"
  • Separates query service into separate service
  • Adds query for historical event emission
  • Add service unit test (in separate file)
  • Adds a default readme for the generated app
  • Add missing dependency on Sites package (caused boot to fail if package was used at boot)
  • Generates app into a directory named "MyApp" (upper camel case) instead of "my-app" to match existing app naming conventions
  • Uses split wit file convention (world.wit, impl.wit) to match existing wit conventions and make imports simpler

@James-Mart James-Mart requested a review from cool-ant December 12, 2024 16:10
@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Dec 12, 2024
@cool-ant
Copy link
Member

This PR seems to replace/improve on the package-templates folder and should (I believe) remove that folder.

@swatanabe
Copy link
Collaborator

This PR seems to replace/improve on the package-templates folder and should (I believe) remove that folder.

I think it does, and github is getting confused for some reason. I see renames when I examine it in git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Experience Related to the experience of developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants