Implementation of per robot account IP allowlist #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joschi36 <joshua@trafficteam.ch>
joschi36
force-pushed
the
robot-IP-allowlist
branch
from
060d343
to
48a31c5
Compare
joschi36
changed the title
joschi36
changed the title
|
@steven-zou @ywk253100 do you have me some feedback? |
|
I will close this as I've got no feedback and already got a different solution. I've created an ingress per project with different whitelist source ranges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to gather a little feedback regarding this one in the community.
For us, it would give more security as we can more granular control it.
Also, I don't know if the complexity to do a change like this in the codebase. Maybe someone can give me an assessment.