Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal bandwidth limit #163

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

bitsf
Copy link
Contributor

@bitsf bitsf commented May 12, 2021

@steven-zou
Copy link
Contributor

Using fixed speed limitation in policy rules seems a little inefficient but simple.

AllForNothing
AllForNothing previously approved these changes Sep 14, 2021
Copy link

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both UI and back-end are finished and implemented the target

ywk253100
ywk253100 previously approved these changes Sep 14, 2021
Signed-off-by: Ziming Zhang <zziming@vmware.com>
@bitsf bitsf dismissed stale reviews from ywk253100 and AllForNothing via 2dfd3a2 October 13, 2021 07:58
@bitsf bitsf force-pushed the proposal_bandwidth_limit branch from 36335b7 to 2dfd3a2 Compare October 13, 2021 07:58
Copy link

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bitsf bitsf merged commit d97b79c into goharbor:master Oct 13, 2021
@bitsf bitsf deleted the proposal_bandwidth_limit branch October 13, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants