Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for CSV export of vulnerability data from Harbor #174

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Proposal for CSV export of vulnerability data from Harbor #174

merged 2 commits into from
Sep 28, 2022

Conversation

prahaladdarkin
Copy link
Contributor

Detailed technical proposal for exporting vulnerability scan data as CSV.

@OrlinVasilev
Copy link
Member

@goharbor/all-maintainers can someone check that please

@prahaladdarkin prahaladdarkin mentioned this pull request Nov 12, 2021
Merged
@danielpacak danielpacak self-requested a review November 19, 2021 08:29
@toastbrotch toastbrotch mentioned this pull request Jan 13, 2022
Open
Vad1mo
Vad1mo reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close this one as #181 also by @prahaladdarkin does also address this proposal.

Am I correct @prahaladdarkin ?

@danielpacak danielpacak removed their request for review March 14, 2022 12:38
@zyyw zyyw mentioned this pull request Jun 13, 2022
Closed
@Vad1mo
Copy link
Member

Vad1mo commented Jun 13, 2022

@prahaladdarkin any updates on your proposal?

@wy65701436 wy65701436 mentioned this pull request Jun 14, 2022
Closed
@prahaladdarkin
Copy link
Contributor Author

@Vad1mo apologize for this delayed response. This proposal was under developement and had a dependency on the completion of the system artifact manager: #181.

The development work for the system artifact manager and the integration has completed. I will be updating this proposal with the latest and greatest of the design changes.

@prahaladdarkin prahaladdarkin mentioned this pull request Jun 27, 2022
Closed
@pthoelken
Copy link

Maybe it's also possible to add the function for exporting as PDF to sending these PDF file to Managers or other persons which don't have access to harbor and only needs the vulnerability informations? Thanks in advanced.

wy65701436
wy65701436 previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

prahaladdarkin added a commit to prahaladdarkin/harbor that referenced this pull request Jul 11, 2022
@prahaladdarkin
Vulnerability Scan Data (CVE) Export Functionality
e5c09c7 
Proposal - goharbor/community#174
Closes - goharbor#17150
Changes:
* CVE Data export to CSV with filtering support.
* Implement CSV data export job for creating CSVs
* APIs to trigger CSV export job executions

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
wy65701436 pushed a commit to goharbor/harbor that referenced this pull request Jul 11, 2022
@prahaladdarkin
Vulnerability scan data export functionality (#15998)
1304521 
Vulnerability Scan Data (CVE) Export Functionality
Proposal - goharbor/community#174
Closes - #17150
Changes:
* CVE Data export to CSV with filtering support.
* Implement CSV data export job for creating CSVs
* APIs to trigger CSV export job executions

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
@prahaladdarkin prahaladdarkin requested review from a team as code owners July 13, 2022 10:47
@prahaladdarkin
Proposal for CSV export of vulnerability data from Harbor
4794493 
Signed-off-by: prahaladd <prahaladd@vmware.com>
@prahaladdarkin
Copy link
Contributor Author

@pthoelken thank you for your input and indeed we can also generate PDF reports. However, the current scope of the implementation is restricted to generating the CSV data for the vulnerability information. CSV files also have the additional advantage of being able to be consumed in downstream analytics tools (including spreadsheet software like MS Excel).
Please feel free to open an enhancement issue for PDF data and that can be prioritized based on discussions in the community :)

@616b2f
Copy link

616b2f commented Sep 28, 2022

Any news when this feature would be available?

@chlins
Copy link
Member

chlins commented Sep 28, 2022 •
edited
Loading

@616b2f Hi, this feature was delivered in the Harbor v2.6.

cc @prahaladdarkin I think we need to merge this pr.

OrlinVasilev
OrlinVasilev approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo removed the request for review from AllForNothing September 28, 2022 10:33
@Vad1mo Vad1mo merged commit 091efce into goharbor:main Sep 28, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
@prahaladdarkin @sluetze
Vulnerability scan data export functionality (goharbor#15998)
33f94f3 
Vulnerability Scan Data (CVE) Export Functionality
Proposal - goharbor/community#174
Closes - goharbor#17150
Changes:
* CVE Data export to CSV with filtering support.
* Implement CSV data export job for creating CSVs
* APIs to trigger CSV export job executions

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@prahaladdarkin
Vulnerability scan data export functionality (goharbor#15998)
57f5719 
Vulnerability Scan Data (CVE) Export Functionality
Proposal - goharbor/community#174
Closes - goharbor#17150
Changes:
* CVE Data export to CSV with filtering support.
* Implement CSV data export job for creating CSVs
* APIs to trigger CSV export job executions

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
@Udayendu
Copy link

@Vad1mo, any idea by when this feature will be available ?

@Udayendu
Copy link

Udayendu commented Apr 3, 2024

@OrlinVasilev / @prahaladdarkin,

I am using v2.10.1 with trivy v0.49.1 but still can't see the export pdf button under the Vulnerabilities tab. Only the following options are available.

image

As per @chlins , this feature was delivered in Harbor v2.6. Not sure why its not visible in the UI, am I missing anything ??

@dpetiz
Copy link

dpetiz commented May 16, 2024

@OrlinVasilev / @prahaladdarkin,

I am using v2.10.1 with trivy v0.49.1 but still can't see the export pdf button under the Vulnerabilities tab. Only the following options are available.

image

As per @chlins , this feature was delivered in Harbor v2.6. Not sure why its not visible in the UI, am I missing anything ??

Version 2.10.2 without too

@hajnalmt
Copy link

This feature was implemented to generate CSV exports only and can be triggered from the Projects page as an Action.
Although the pdf report would have been a nice addition, and the API has it as a format type, it doesn't work and gives back a csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@OrlinVasilev OrlinVasilev OrlinVasilev approved these changes

@Vad1mo Vad1mo Vad1mo approved these changes

@wy65701436 wy65701436 wy65701436 left review comments

Assignees
No one assigned
Labels
kind/proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@prahaladdarkin @OrlinVasilev @Vad1mo @pthoelken @616b2f @chlins @Udayendu @dpetiz @hajnalmt @wy65701436