Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is recommended that the expost.core.ingress field be changed to optional #955

Closed
lengrongfu opened this issue Aug 27, 2022 · 2 comments
Closed

It is recommended that the expost.core.ingress field be changed to optional #955

lengrongfu opened this issue Aug 27, 2022 · 2 comments
Assignees
@lengrongfu
Labels
kind/requirement New feature or request

Comments

@lengrongfu
Copy link
Collaborator

What can we help you?

Currently ExternalURL and expost.core.ingress fields are required, can they be changed to not required?
Currently we have a scenario where we only need to access the Harbor backend service, and it is accessed inside the k8s cluster, so it can be accessed through the service ClusterIp type of harbor core.
@heww heww added kind/requirement New feature or request and removed needs-triage labels Sep 27, 2022
@heww
Copy link
Collaborator

heww commented Sep 27, 2022

ExternalURL is a required configuration for the harbor-core because the harbor-core uses this configuration to generate the auth service URL.

ingress can be changed to not required

ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this issue Nov 4, 2022
@ShouEnHsiao
fix: make expose core ingress optional
e960fba 
goharbor#955

Signed-off-by: Shou-En Hsiao <shouenhsiao@google.com>
@ShouEnHsiao ShouEnHsiao mentioned this issue Nov 4, 2022
Closed
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this issue Nov 7, 2022
@ShouEnHsiao
fix: make expose core ingress optional
3f81d70 
goharbor#955

Signed-off-by: Shou-En Hsiao <shouenhsiao@google.com>
@ShouEnHsiao ShouEnHsiao mentioned this issue Nov 7, 2022
Merged
bitsf pushed a commit that referenced this issue Nov 29, 2022
@ShouEnHsiao @bitsf
fix: make expose core ingress optional
30d6d29 
#955

Signed-off-by: Shou-En Hsiao <shouenhsiao@google.com>
@thcdrt
Copy link
Collaborator

thcdrt commented Dec 2, 2022

Fixed in #975

@thcdrt thcdrt closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengrongfu lengrongfu

Labels
kind/requirement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bitsf @heww @lengrongfu @thcdrt