Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Support custom annotations #969

Closed
xoanmi opened this issue Oct 5, 2022 · 2 comments · Fixed by #973
Closed

Feature request - Support custom annotations #969

xoanmi opened this issue Oct 5, 2022 · 2 comments · Fixed by #973
Labels
kind/requirement New feature or request

Comments

@xoanmi
Copy link
Contributor

xoanmi commented Oct 5, 2022

Is your feature request related to a problem? Please describe.
Currently, the operator doesn't support injecting custom annotations.

Describe the solution you'd like

apiVersion: goharbor.io/v1beta1
kind: HarborCluster
metadata:
  # These annotations should be injected into all objects created by the operator
  annotations:
    foo: 'xyz'
spec:
  core:
    # These annotations should be injected only into core components
    annotations:
      bar: 'abc'

Describe the main design/architecture of your solution
Be able to define generic annotations that will be injected in all objects as well as custom annotations per component (core, registry, trivy, etc).

Additional context
We would like to configure Monitor Prometheus metrics with dynatrace so we need to annotate the pods who export metrics: exporter, core, jobservice, and registry.

annotations:
    metrics.dynatrace.com/scrape: 'true'
    metrics.dynatrace.com/path: '/path/to-metrics'
    metrics.dynatrace.com/port: '9001'
@bitsf
Copy link
Collaborator

bitsf commented Oct 11, 2022

this seems be required by issue #967

@xoanmi
Copy link
Contributor Author

xoanmi commented Oct 17, 2022

this seems be required by issue #967

Hi @bitsf! We have pushed a PR to support custom annotations for deployment templates: #973

xoanmi added a commit to xoanmi/harbor-operator that referenced this issue Oct 17, 2022
Co-authored-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
Co-authored-by: Carlos Vega <carlos.vega@dynatrace.com>

Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
xoanmi added a commit to xoanmi/harbor-operator that referenced this issue Oct 25, 2022
Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
bitsf pushed a commit that referenced this issue Nov 22, 2022
Co-authored-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
Co-authored-by: Carlos Vega <carlos.vega@dynatrace.com>

Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
bitsf pushed a commit that referenced this issue Nov 22, 2022
Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
cagiti pushed a commit to giantswarm/harbor-operator-upstream that referenced this issue Nov 22, 2022
Co-authored-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
Co-authored-by: Carlos Vega <carlos.vega@dynatrace.com>

Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
cagiti pushed a commit to giantswarm/harbor-operator-upstream that referenced this issue Nov 22, 2022
Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/requirement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants