Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a step-by-step install guide on KIND k8s #32

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

bitsf
Copy link
Collaborator

@bitsf bitsf commented Mar 25, 2020

No description provided.

@holyhope
Copy link
Collaborator

Is this PR still needed?
#27 is merged

@steven-zou steven-zou added documentation Improvements or additions to documentation area/installation labels Mar 31, 2020
@steven-zou steven-zou requested a review from holyhope March 31, 2020 03:00
@steven-zou steven-zou added the release/0.5 Issues for the release 0.5 label Mar 31, 2020
Copy link
Collaborator

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left

EOF
```

- install go gofmt golangci-lint kube-apiserver kubebuilder kubectl kustomize pkger etcd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitsf

Could you please list the related links of installation documents of such tools?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think that the make dev-tools command can be useful here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make dev-tools not fully work yet, so add some workaround.
You can help check if this workaround can be add to the makefile too

@steven-zou
Copy link
Collaborator

Is this PR still needed?
#27 is merged

@bitsf

I think you can update the extra contents to the installation doc introduced in #27?
cc @holyhope

@bitsf
Copy link
Collaborator Author

bitsf commented Apr 3, 2020

Is this PR still needed?
#27 is merged

I'm not sure yet, I just find the origin installation doc is more common, but user may still not know how to do in some specific case, or how to merge them.
What do you suggest, is this doc useful ?

EOF
```

- install go gofmt golangci-lint kube-apiserver kubebuilder kubectl kustomize pkger etcd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think that the make dev-tools command can be useful here?

docs/install-with-kind-k8s.md Outdated Show resolved Hide resolved
```bash
helm install nginx stable/nginx-ingress

kubectl patch deployments nginx-nginx-ingress-controller -p '{"spec":{"template":{"spec":{"containers":[{"name":"nginx-ingress-controller","ports":[{"containerPort":80,"hostPort":80},{"containerPort":443,"hostPort":443}]}],"nodeSelector":{"ingress-ready":"true"},"tolerations":[{"key":"node-role.kubernetes.io/master","operator":"Equal","effect":"NoSchedule"}]}}}}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested you changes about that awful patch: 9fa9bff
Please reuse it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not work yet

@bitsf bitsf force-pushed the doc_install_with_kind_k8s branch 2 times, most recently from f138664 to 0a68e3a Compare April 8, 2020 11:42
renmaosheng
renmaosheng previously approved these changes Apr 8, 2020
@steven-zou
Copy link
Collaborator

@bitsf @holyhope

Let's keep this installation guide for Kind K8s as a separate document so that the user can easily follow to have a try.

@bitsf bitsf force-pushed the doc_install_with_kind_k8s branch 4 times, most recently from 4c74222 to 979d31f Compare April 9, 2020 11:54
Signed-off-by: Ziming Zhang <zziming@vmware.com>
@bitsf bitsf force-pushed the doc_install_with_kind_k8s branch from 979d31f to 734b308 Compare April 9, 2020 11:57
@bitsf bitsf merged commit e2c2542 into goharbor:master Apr 13, 2020
@bitsf bitsf deleted the doc_install_with_kind_k8s branch April 1, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation documentation Improvements or additions to documentation release/0.5 Issues for the release 0.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants