-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a step-by-step install guide on KIND k8s #32
Conversation
Is this PR still needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments left
docs/install-with-kind-k8s.md
Outdated
EOF | ||
``` | ||
|
||
- install go gofmt golangci-lint kube-apiserver kubebuilder kubectl kustomize pkger etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please list the related links of installation documents of such tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you think that the make dev-tools
command can be useful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make dev-tools
not fully work yet, so add some workaround.
You can help check if this workaround can be add to the makefile too
I'm not sure yet, I just find the origin installation doc is more common, but user may still not know how to do in some specific case, or how to merge them. |
docs/install-with-kind-k8s.md
Outdated
EOF | ||
``` | ||
|
||
- install go gofmt golangci-lint kube-apiserver kubebuilder kubectl kustomize pkger etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you think that the make dev-tools
command can be useful here?
docs/install-with-kind-k8s.md
Outdated
```bash | ||
helm install nginx stable/nginx-ingress | ||
|
||
kubectl patch deployments nginx-nginx-ingress-controller -p '{"spec":{"template":{"spec":{"containers":[{"name":"nginx-ingress-controller","ports":[{"containerPort":80,"hostPort":80},{"containerPort":443,"hostPort":443}]}],"nodeSelector":{"ingress-ready":"true"},"tolerations":[{"key":"node-role.kubernetes.io/master","operator":"Equal","effect":"NoSchedule"}]}}}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested you changes about that awful patch: 9fa9bff
Please reuse it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not work yet
f138664
to
0a68e3a
Compare
0a68e3a
to
0f1c093
Compare
4c74222
to
979d31f
Compare
Signed-off-by: Ziming Zhang <zziming@vmware.com>
979d31f
to
734b308
Compare
No description provided.