doc(Development): Remove cert-manager deployment #735
Conversation
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
thcdrt
force-pushed
the
remove-cert-manager-deployment-from-development-doc
branch
from
425ff79
to
febedf0
Compare
| ```bash | ||
| helm install cert-manager \ | ||
| --namespace cert-manager \ | ||
| --version v0.12.0 \ | ||
| jetstack/cert-manager | ||
| ``` |
There was a problem hiding this comment.
Would it be better to replace it with kubectl apply -f https://github.com/jetstack/cert-manager/releases/latest/download/cert-manager.yaml
There was a problem hiding this comment.
I don't know if it's really relevant to do it here as it's already started in Makefile
There was a problem hiding this comment.
I'm not quite sure if this area is worth modifying
There was a problem hiding this comment.
If want to let the developer use makefile to prepare the env, you can delete the section. But it seems we should explicitly mention the developer can use makefile to install prerequisite like cert-manager here. WDYT?
There was a problem hiding this comment.
Why not, we could redirect to the certmanager Makefile target, but in this case to be consistent we should talk of nginx ingress, postgresql-operator and redis-operator too, don't you think ?
There was a problem hiding this comment.
Can we use helm to solve the problem of dependent installation?
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Hello,
I think we can remove this cert manager command because it causes issues when running the run Makefile target that tries to launch cert-manager too but on a more recent version. I think we should let the run target handle this.
Signed-off-by: Thomas Coudert thomas.coudert@ovhcloud.com