Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): clean status reason when reconcile success #752

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 20, 2021

Signed-off-by: chlins chlins.zhang@gmail.com

Copy link
Collaborator

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the fix/configuration-crd-status-reason-inconsistent branch from 06328de to 87cafcb Compare August 20, 2021 01:20
Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins merged commit 69527e6 into goharbor:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants