Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): Set default ingress class when installing nginx-ingres… #775

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

thcdrt
Copy link
Collaborator

@thcdrt thcdrt commented Sep 21, 2021

Hello,

We need to set a default ingress class, else harbor and notary ingresses are not working.

Signed-off-by: Thomas Coudert thomas.coudert@ovhcloud.com

…s with helm

Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
@thcdrt thcdrt force-pushed the fix-set-default-ingress-class branch from acc7bf7 to 753ea8d Compare September 21, 2021 09:04
Copy link
Collaborator

@sguyennet sguyennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cndoit18 cndoit18 merged commit 7e1acc4 into goharbor:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants