Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gcs config #830

Merged
merged 4 commits into from
Jan 19, 2022
Merged

fix gcs config #830

merged 4 commits into from
Jan 19, 2022

Conversation

soulseen
Copy link
Collaborator

fix #828

Signed-off-by: soulseen zhuxiaoyang1996@gmail.com

Signed-off-by: soulseen <zhuxiaoyang1996@gmail.com>
Signed-off-by: soulseen <zhuxiaoyang1996@gmail.com>
Copy link
Collaborator

@bitsf bitsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chartmuseum pod can't start up
image

@bitsf
Copy link
Collaborator

bitsf commented Jan 8, 2022

test step

  1. add a secret with google service token with storage admin role
apiVersion: v1
kind: Secret
metadata:
  name: gcs-secretkey
  namespace: cluster-sample-ns
data:
  GCS_KEY_DATA: <base64 encoded of the token file content>
  1. change storage spec of HarborCluster
spec:
  storage:
    kind: Gcs
    spec:
      redirect:
        enable: true
      gcs:
        keyDataRef: gcs-secretkey
        bucket: thebucketname
        pathPrefix: harbor-operator/test

Signed-off-by: soulseen <zhuxiaoyang1996@gmail.com>
Signed-off-by: soulseen <zhuxiaoyang1996@gmail.com>
@soulseen soulseen requested a review from bitsf January 15, 2022 15:36
@soulseen
Copy link
Collaborator Author

@bitsf fixed, pls review again. thanks

@soulseen soulseen merged commit c17f9cc into goharbor:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcr storage not work
3 participants