fix(controller): use update instead of patch #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cndoit18
changed the title
steven-zou
reviewed
Apr 15, 2022
|
we need to do more test this first, the fix is a little tricky. |
|
refer issue |
cndoit18
force-pushed
the
fix-issue-824
branch
5 times, most recently
from
c297ec1
to
f959bba
Compare
bitsf
approved these changes
May 12, 2022
yxxhero
reviewed
May 12, 2022
yxxhero
reviewed
May 12, 2022
Signed-off-by: cndoit18 <cndoit18@outlook.com>
yxxhero
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cndoit18 cndoit18@outlook.com
Fixes: #825
Fixes: #824
Fixes: #743