Add github action to assign maintainers to PRs #983
Conversation
Signed-off-by: Marcel Mueller <marcel.mueller1@rwth-aachen.de>
.github/auto-assignees.yaml
Outdated
| - wip | ||
| - DO NOT MERGE | ||
| enable_group_assignment: true | ||
| number_of_reviewers: 3 |
| @@ -0,0 +1,30 @@ | |||
| # This assigns a PR to its author | |||
| addAssignees: true | |||
There was a problem hiding this comment.
this seems not required currently
There was a problem hiding this comment.
Why do you think so? Every example (even the upstream one) explicitly sets this to true:
https://github.com/kentaro-m/auto-assign-action#single-reviewers-list
And matches what harbor repo has set:
https://github.com/goharbor/harbor/blob/a826720cc94dd9ac8d3495ba74a913055a2a9268/.github/auto-assignees.yml#L3
There was a problem hiding this comment.
it should be either true or author, we need true so we have array of assignees
There was a problem hiding this comment.
please add wy65701436 , and assign to him
There was a problem hiding this comment.
Do you mean adding @wy65701436 to the list of assignees?
I took the current list from here: https://github.com/goharbor/harbor-operator/blob/master/MAINTAINERS
There was a problem hiding this comment.
@MarcelMue correct but Yan Wang @wy65701436 is currently the overall tech lead for Harbor so it's good to have him :)
There was a problem hiding this comment.
@wy65701436 can you confirm please
Signed-off-by: Marcel Mueller <marcel.mueller1@rwth-aachen.de>
Signed-off-by: Marcel Mueller <marcel.mueller1@rwth-aachen.de>
|
I think that's is done shall we merge ? @goharbor/all-maintainers |
Signed-off-by: Marcel Mueller marcel.mueller1@rwth-aachen.de