Return 401 for GET request to /v2 API for public artifacts. #14768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits make sure when the request does not carry authorization headers, the HEAD and GET will get the same response code. This change should be made due to goharbor#14711 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #14768 +/- ##
==========================================
+ Coverage 66.22% 66.42% +0.20%
==========================================
Files 940 937 -3
Lines 74477 75355 +878
Branches 2140 2194 +54
==========================================
+ Hits 49320 50055 +735
- Misses 21256 21381 +125
- Partials 3901 3919 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ywk253100
approved these changes
Apr 29, 2021
heww
approved these changes
Apr 29, 2021
| @@ -60,7 +60,8 @@ func (rc *reqChecker) check(req *http.Request) (string, error) { | |||
| return getChallenge(req, al), fmt.Errorf("unauthorized to list catalog") | |||
| } | |||
| } | |||
| if a.target == repository && req.Header.Get(authHeader) == "" && req.Method == http.MethodHead { // make sure 401 is returned for CLI HEAD, see #11271 | |||
| if a.target == repository && req.Header.Get(authHeader) == "" && | |||
| (req.Method == http.MethodHead || req.Method == http.MethodGet) { // make sure 401 is returned for CLI HEAD, see #11271 | |||
| return getChallenge(req, al), fmt.Errorf("authorize header needed to send HEAD to repository") | |||
There was a problem hiding this comment.
The error message here says authorize header needed to send HEAD to repository but this is true for GET too (with this PR), right? With (req.Method == http.MethodHead || req.Method == http.MethodGet)
cc @reasonerjt
There was a problem hiding this comment.
Should it says HEAD or GET ? Or maybe interpolate the req.Method in the string for accuracy? Something like this maybe? -
fmt.Errorf("authorize header needed to send %s to repository", req.Method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits make sure when the request does not carry authorization
headers, the HEAD and GET will get the same response code. This change
should be made due to #14711
Signed-off-by: Daniel Jiang jiangd@vmware.com