Adding CREATE/DELETE Label for Robot Account

[DandyDeveloper]

This is a basic implementation of adding CREATE/DELETE options for labels on both Artifacts AND Chartrepo charts.

Tests will follow, when I understand how your Python tests work :)

• fixes Robot Account "403 FORBIDDEN" on "Add" or "Removal" or artifact (image) label #15788

[DandyDeveloper]

@YangJiao0817 @wy65701436 FYI, I'm a bit confused by your testing on the API Tests. I can't find ref

https://github.com/dandydeveloper/harbor/blob/068d1d46ca3f9f2d8cb3fca0fb6649bd9390c54d/tests/apitests/python/library/artifact.py#L57

In order to create a delete label for the client correctly.

[YangJiao0817]

@DandyDeveloper Please execute make swagger_client in the harbor/ directory, this can solve your problem.

[codecov]

Codecov Report

Merging #15815 (402f3d0) into master (2ec8a41) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #15815      +/-   ##
==========================================
+ Coverage   66.83%   66.86%   +0.02%     
==========================================
  Files         935      935              
  Lines       77679    77716      +37     
  Branches     2290     2290              
==========================================
+ Hits        51913    51961      +48     
+ Misses      21762    21751      -11     
  Partials     4004     4004              

Flag	Coverage Δ
unittests	66.86% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ide-nav/system-robot-accounts/system-robot-util.ts	67.64% <100.00%> (ø)
src/common/utils/encrypt.go	66.66% <0.00%> (-2.78%)	⬇️
...tegration/tag-retention/tag-retention.component.ts	29.95% <0.00%> (-2.21%)	⬇️
src/controller/robot/controller.go	57.60% <0.00%> (-1.29%)	⬇️
src/common/utils/utils.go	72.86% <0.00%> (-0.62%)	⬇️
src/core/auth/authenticator.go	58.13% <0.00%> (ø)
src/pkg/reg/adapter/jfrog/adapter.go	59.89% <0.00%> (ø)
...lnerability-scanning/result-bar-chart.component.ts	33.65% <0.00%> (ø)
...ry/artifact/artifact-tag/artifact-tag.component.ts	30.92% <0.00%> (+0.65%)	⬆️
src/portal/src/app/shared/units/shared.utils.ts	24.35% <0.00%> (+1.28%)	⬆️
... and 4 more

[AllForNothing]

@DandyDeveloper Please also modify harbor/tests/resources/Harbor-Pages/Robot_Account.robot, and add "Delete Artifact label", "Create Helm Chart label" and "Delete Helm Chart label" as below, this will make sure e2e testing can run successfully

[DandyDeveloper]

@AllForNothing All done. Thanks for the review.

[AllForNothing]

LGTM

[AllForNothing]

@DandyDeveloper One more thing, please squash your commits into one

[wy65701436]

lgtm, thanks

[DandyDeveloper]

@AllForNothing Look good?

[AllForNothing]

@AllForNothing Look good?

Yes. Thanks for your contribution

[DandyDeveloper]

@YangJiao0817 @AllForNothing @wy65701436 This has been skipped for several releases now.

Can I please get this included in a release?

[AllForNothing]

@DandyDeveloper This is already included in the upcoming 2.5

[DandyDeveloper]

@AllForNothing Oh, sorry I don't see a tag anywhere so I assume it wasn't. Thank you.