-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade distribution to 2.8 #16190
Upgrade distribution to 2.8 #16190
Conversation
725b3e0
to
b8a9030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There is some progress on the official 2.8 release distribution/distribution#3552 |
It states
|
@zyyw thanks for catching that. Im running into some limitations with When attempting to pin to a specific commit it is silently falling back to the previous release. The go get docs do not explicitly state that you can pin to a commit...
I am also unable to pin to the release/2.8 branch. go get says you can pin to a branch but this specific branch appears to violate a naming convention
|
Distribution cut a 2.8 Beta release but has not back ported the IRSA fix that we need into it |
@darend Distribution has released v2.8.0 version recently. https://github.com/distribution/distribution/releases/tag/v2.8.0 |
a1b3376
to
3934fde
Compare
Signed-off-by: Daren Desjardins <darend@gmail.com>
Signed-off-by: Daren Desjardins <darend@gmail.com>
3934fde
to
6c211b3
Compare
@chlins It is updated to 2.8 |
what
Upgrade the distribution package to 2.8
why
Harbor is currently on 2.7.1 which was released in 2019. Full release notes available here https://github.com/distribution/distribution/releases/tag/v2.8.0
EDIT: IRSA support not included in this release
See distribution/distribution#3552 (comment)
The 2.7 release uses an out of date AWS SDK which does not support the AWS AssumeRoleWithWebIdentity required for deployments under Kubernetes that use IRSA. This was fixed in the 2.8 release, see distribution/distribution#3097. Support for IRSA is of growing importance. It is the recommended solution when running Kubernetes on AWSUnfortunately while distribution has a 2.8 branch they have not made a release. I pinned the upgrade to the last commit of the 2.8 release branchIRSA Documentation:Overview https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/Required AWS SDK versions https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.htmlThis fixes goharbor/harbor-helm#725