-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimize quota checking when pushing images #17392
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17392 +/- ##
==========================================
+ Coverage 67.34% 67.36% +0.02%
==========================================
Files 980 980
Lines 106829 106750 -79
Branches 2665 2665
==========================================
- Hits 71943 71915 -28
+ Misses 31019 30976 -43
+ Partials 3867 3859 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lengrongfu thank you for your PR super happy to see your contribution! someone from the @goharbor/all-maintainers will review soon :) |
@lengrongfu I will take the time to evaluate this PR, thank you for your contribution. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@OrlinVasilev Hi, can we arrange maintainers who have time or are willing to review. |
Hi @lengrongfu will add it to the next community meeting agenda for review but it will be great if you can join us there! Thanks! |
I'd love to, I'll get in touch with you on Slack, thanks. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@lengrongfu can you please remind me did you presented that on the community meetings ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0c2c983
to
97d6a9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: lengrongfu <1275177125@qq.com>
97d6a9e
to
c42b183
Compare
Signed-off-by: lengrongfu <1275177125@qq.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Signed-off-by: lengrongfu <1275177125@qq.com>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Create a zero-length resource when calling the
post /v2/library/ubuntu/blobs/uploads/
API to check if the quota is full.Issue being fixed
Fixes #17390
Please indicate you've done the following: