-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Portal french translation #18289
Improve Portal french translation #18289
Conversation
4539928
to
ba179b4
Compare
@thcdrt Could you ask at least one other French speaker to review your PR? |
Codecov Report
@@ Coverage Diff @@
## main #18289 +/- ##
===========================================
+ Coverage 44.54% 67.46% +22.92%
===========================================
Files 233 971 +738
Lines 13022 106223 +93201
Branches 2660 2649 -11
===========================================
+ Hits 5800 71667 +65867
- Misses 6926 30720 +23794
- Partials 296 3836 +3540
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little mistakes
ba179b4
to
5c4fe59
Compare
5c4fe59
to
51e513f
Compare
could you help to rebase then we are good to merge |
51e513f
to
87932ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review here!
Another comment: for "pull", sometimes you use "tirer", sometimes "récupérer".
It would be fin to use always the same verb (I prefer "récupérer"), or just let "pull"
Thank you for your review, indeed, as answered to Theo, I asked myself which one to chose but as I couldn't take a decision I let it as it was. |
ee4ffc7
to
335cb31
Compare
Yes, I think keeping "push" and "pull" everywhere will make it more consistent, thank you |
Thank you all for your reviews, all suggestions have been applied |
0be33e6
to
ed3a0ce
Compare
ed3a0ce
to
e82ef27
Compare
@thcdrt Please ping me if this PR is good to merge,I can help to merge it |
Hello @AllForNothing, for me PR is good to merge :) |
da2c9d9
to
cc5f410
Compare
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
cc5f410
to
6f9fd05
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Fix missing translations + typo on Portal French file.
Thomas