Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: disable the scan related button when installation without scanner or scanner deactived #20661

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 25, 2024

Disable the scan related button when installation without scanner or scanner deactived.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…r or scanner deactived

Signed-off-by: chlins <chlins.zhang@gmail.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@08e5553). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20661   +/-   ##
=================================================
  Coverage                  ?   68.99%           
=================================================
  Files                     ?      798           
  Lines                     ?    99708           
  Branches                  ?        0           
=================================================
  Hits                      ?    68798           
  Misses                    ?    27131           
  Partials                  ?     3779           
Flag Coverage Δ
unittests 68.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MinerYang MinerYang added the release-note/update Update or Fix label Jun 26, 2024
@MinerYang MinerYang enabled auto-merge (squash) June 26, 2024 04:35
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 04e3606 into goharbor:release-2.11.0 Jun 26, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants