refactor: unify the mock file generation #20765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
force-pushed
the
feat/mock-distribution
branch
from
d607936 to
1ba9d84
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20765 +/- ##
==========================================
+ Coverage 45.36% 46.27% +0.90%
==========================================
Files 244 247 +3
Lines 13333 13778 +445
Branches 2719 2845 +126
==========================================
+ Hits 6049 6376 +327
- Misses 6983 7070 +87
- Partials 301 332 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
chlins
force-pushed
the
feat/mock-distribution
branch
from
1ba9d84 to
c74c3a1
Compare
chlins
changed the title
chlins
force-pushed
the
feat/mock-distribution
branch
8 times, most recently
from
de86509 to
c6c3726
Compare
1. Mock remote interface for distribution manifest by mockery package feature. 2. Refactor hand-generated mock files to automated management generation. 3. Clean useless mocks. Signed-off-by: chlins <chlins.zhang@gmail.com>
chlins
force-pushed
the
feat/mock-distribution
branch
from
c6c3726 to
11c0dc5
Compare
kunal-511
pushed a commit
to kunal-511/harbor_local
that referenced
this pull request
Aug 22, 2024
1. Mock remote interface for distribution manifest by mockery package feature. 2. Refactor hand-generated mock files to automated management generation. 3. Clean useless mocks. Signed-off-by: chlins <chlins.zhang@gmail.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature.
generation.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: