-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes-20799 can't remove artifact labels #20816
Conversation
Signed-off-by: xuelichao <xuel@vmware.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20816 +/- ##
===========================================
+ Coverage 45.36% 66.29% +20.92%
===========================================
Files 244 1045 +801
Lines 13333 113988 +100655
Branches 2719 2845 +126
===========================================
+ Hits 6049 75570 +69521
- Misses 6983 34297 +27314
- Partials 301 4121 +3820
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified and LGTM
Thanks @xuelichao
Signed-off-by: xuelichao <xuel@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Thank you for contributing to Harbor!
can't remove artifact labels
Issue being fixed
Fixes #20799
Please indicate you've done the following: