Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes-20799 can't remove artifact labels #20816

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

xuelichao
Copy link
Contributor

Thank you for contributing to Harbor!

can't remove artifact labels

Issue being fixed

Fixes #20799

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao requested a review from a team as a code owner August 7, 2024 05:10
@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (c8c11b4) to head (e616ac2).
Report is 250 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20816       +/-   ##
===========================================
+ Coverage   45.36%   66.29%   +20.92%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113988   +100655     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75570    +69521     
- Misses       6983    34297    +27314     
- Partials      301     4121     +3820     
Flag Coverage Δ
unittests 66.29% <ø> (+20.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and LGTM

Thanks @xuelichao

@MinerYang MinerYang merged commit ec77bd9 into goharbor:main Aug 7, 2024
13 of 14 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
Signed-off-by: xuelichao <xuel@vmware.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Remove image Labels
5 participants