-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OIDC based SSO #6966
Conversation
Signed-off-by: Keith Bartholomew <keith.bartholomew@rackspace.com>
Signed-off-by: Keith Bartholomew <keith.bartholomew@rackspace.com>
Signed-off-by: Keith Bartholomew <keith.bartholomew@rackspace.com>
Signed-off-by: Keith Bartholomew <keith.bartholomew@rackspace.com>
Signed-off-by: Keith Bartholomew <keith.bartholomew@rackspace.com>
Thanks a lot for submitting PR to cover the fantastic OIDC supporting which the whole community is looking forward to. However, based on the Harbor governance model, the changes should be summarized as a proposal and submitted to the community for a widely discussed before raising code PRs. Only the proposal is accepted after review and voting by maintainers, the related code changes (PRs) can be accepted. Is it ok to draft a proposalto describe your main ideas and let the community have a review? @ktbartholomew Moreover, a suggestion, many other community users have interested in this feature, maybe you can have a try to contact them to set up an |
@ktbartholomew |
@steven-zou It looks like a proposal had been made, but a revised draft is being worked on privately (see goharbor/community#17 (comment)). I'm happy to review and contribute to the proposal, but want to make sure I'm helping in the right place. |
@ktbartholomew |
Slack is good, didn't know you had a workspace. Joining now! |
This addresses #6616.
Feedback welcome, as I'm sure there will be lots of opinions from more experienced contributors about things that I haven't done correctly 😄