Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next and prev links point in opposite directions.... #21

Closed
rdwatters opened this issue May 26, 2017 · 3 comments
Closed

Next and prev links point in opposite directions.... #21

rdwatters opened this issue May 26, 2017 · 3 comments
Assignees

Comments

@rdwatters
Copy link
Contributor

This could be semi-related to #20 if you already have this in mind, but as a LTR site, I think it makes more sense to have "<" == "prev" and ">" == "next". I'm guessing you're running into the same quirk that I ran into with my previous theme; i.e., you call .NextInSection but it's for the prev link. Here's some context:

https://github.com/rdwatters/hugo-docs-concept/blob/master/themes/hugo-docs-concept/layouts/partials/content-footer.html#L23-L44

@budparr budparr self-assigned this May 26, 2017
@budparr
Copy link

budparr commented May 27, 2017

From @digitalcraftsman

I've a quick question regarding the prev/next buttons in the new theme, e.g. like on this page in the sidebar below the TOC and at the bottom of the page users can go the previous or next page in a section.

In order to go to the Quickstart in the linked example I have to click the > caret in the sidebar or the right link in the footer. However, the Quickstart guide is ordered before the "Install Hugo" page.
Intuitively I would expect it the other way around. Reading a book might be a good metaphor: if I want to go to the previous page I would move my hand to the left side of the book to do the flip.

possibly related: gohugoio/hugo#1061

@budparr
Copy link

budparr commented May 27, 2017

I fixed these. It's fairly unintuitive on the code side, so thanks for pointing it out. I'll take a crack at better styling layter. Thanks guys.

@budparr budparr closed this as completed May 27, 2017
@rdwatters
Copy link
Contributor Author

Agreed on the unintuitive part for sure. But with so many sites using it, it strikes me as unreversible. Maybe the solution is for Hugo to someday have .NextIn "section" or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants