Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove smooth scroll script #53

Closed
wants to merge 1 commit into from
Closed

Conversation

budparr
Copy link

@budparr budparr commented Jul 19, 2017

The smooth scroll script breaks the back button and presents accessibility issues with focus and motion.

Fixes #52

Reference: https://css-tricks.com/smooth-scrolling-accessibility/

The smooth scroll script breaks the back button and presents accessibility issues with focus and motion.

Fixes #52

Reference: https://css-tricks.com/smooth-scrolling-accessibility/
@budparr
Copy link
Author

budparr commented Jul 19, 2017

I don't think this is a controversial change, but @rdwatters as you had requested this feature, thought I'd give you an opportunity to weigh in.

@budparr
Copy link
Author

budparr commented Jul 19, 2017

Closing to do as a fork.

@budparr budparr closed this Jul 19, 2017
@rdwatters
Copy link
Contributor

Agreed it's a good idea to remove the current implementation. The previous smoothscroll updated the URL hash both on click and scroll, and copied the URL with hash to the user's clipboard if clicking on the heading directly. This is my fault for not being more specific, and I also just learned about my shortcomings with that article, which I appreciate you sharing. Thanks @budparr!

Note: I'm not bragging about the previous smoothscroll; as I believe I mentioned on Gitter, my JS/JQ was full of 🍝 🍝 🍝 .

@budparr
Copy link
Author

budparr commented Jul 19, 2017 via email

@digitalcraftsman
Copy link
Member

Closing to do as a fork.

Based on that comment I conclude that you (@budparr) moved the development to your own fork or you're already done with your changes.

If so please delete the corresponding branch in this repo to keep things clean.

@budparr budparr deleted the budparr/fix-smooth-scroll branch July 20, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants