Phase 1 of #24
Merged
Phase 1 of #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating markers > 2 as Goldmark 1.7.2. This new implementation changes a few details for all inline tags that expect two runes as the marker. Especially the combination `~~CO~2~~~` won't be rendered as expected.
|
@bowman2001 Thank you. I will try to take this for a spin either later today or early tomorrow. |
|
@bowman2001 This looks good. I carefully examined the test cases you removed, and I'm fine with the results. I'll will take care of the Hugo side of things and update the documentation. |
|
@bowman2001 Thanks again for reacting so quickly to the upstream change. Much appreciated. |
|
You're welcome! And thanks for all your good work. I've learned a lot, again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new delete extension that allows to avoid the possible conflict of the extra subscript extension with the new strike-through extension. This issue is discussed in gohugoio/hugo#12597.
Also adopts two changes in the original Goldmark code for strike-through.