resources.GetRemote HEAD method errors with unexpected EOF

[jmooring]

Reference: https://discourse.gohugo.io/t/42272/3

When I do this:

{{ $url := "https://gohugo.io/img/hugo.png" }}
{{ $opts := dict "method" "head" }}
{{ with resources.GetRemote $url $opts }}
  {{ with .Err }}
    {{ errorf "Unable to get remote resource: %s" . }}
  {{ else }}
    {{ .Content }}
  {{ end }}
{{ else }}
  {{ errorf "Unable to get remote resource: %s" $url }}
{{ end }}

I get:

Unable to get remote resource: error calling resources.GetRemote: failed to read remote resource “https://gohugo.io/img/hugo.png”: unexpected EOF

But the response is captured and cached in:
/tmp/hugo_cache/my-project/filecache/getresource/6247740232174893946

[jmooring]

cc: @vanbroup

[vanbroup]

A quick code scan, we should check if the response body is nil bore reading it, as a HEAD response doesn't contain a body.

https://github.com/gohugoio/hugo/blob/master/resources/resource_factories/create/remote.go#L138

should check if res.Body is nil.

I can create a PR to fix and test this next week.

[bep]

should check if res.Body is nil.

I'm checking this now and in @jmooring 's test case the body is not nil, ContentLength is reported as 18210, yet Go is throwing this unexpected EOF error.

[bep]

OK, the Mozilla docs are useful here:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD

So, the correct way to handle this is to just ignore the body when the method is HEAD. I will create a pull request.

[bep]

... but that said, I don't see the value of a Resource object from a HEAD request without the ContentLength etc. response info ... I'll see if I can add that to the mix. We have a .Data map that we could stuff this info in.

[oclero]

🥳

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.