Check potential output format issue with output formats in hugo server on GitHub action #11089

bep · 2023-06-13T06:25:14Z

https://discourse.gohugo.io/t/hugo-serve-randomly-fails-to-load-pages-and-alias/44771/8

This isn't obvious to me, but I will try to read through the code to see what may happen. If someone have a project that somehow reproduces this reliably, please shout.

jmichelgarcia · 2023-06-13T10:14:59Z

Hey @bep, it took some time but I think I was able to reproduce on a slimmed and public repository.

Clean build:

4 pages
3 aliases

hugo: collected modules in 692 ms
Start building sites … 
hugo v0.113.0+extended linux/amd[6](https://github.com/jmichelgarcia/docs-temp-2/actions/runs/5254069557/jobs/9492217795#step:7:7)4 BuildDate=unknown
WARN 2023/06/13 10:05:5[7](https://github.com/jmichelgarcia/docs-temp-2/actions/runs/5254069557/jobs/9492217795#step:7:8) .File.UniqueID on zero object. Wrap it in if or with: {{ with .File }}{{ .UniqueID }}{{ end }}

                   | EN | FR  
-------------------+----+-----
  Pages            |  4 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  3 |  0  
  Sitemaps         |  0 |  0  
  Cleaned          |  0 |  0  

Total in 11[8](https://github.com/jmichelgarcia/docs-temp-2/actions/runs/5254069557/jobs/9492217795#step:7:9)5 ms

Glitched build

1 page
no aliases

hugo: collected modules in 1259 ms
Start building sites … 
hugo v0.113.0+extended linux/amd[6](https://github.com/jmichelgarcia/docs-temp-2/actions/runs/5254100494/jobs/9492291541#step:7:7)4 BuildDate=unknown

                   | EN | FR  
-------------------+----+-----
  Pages            |  1 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  0 |  0  
  Sitemaps         |  1 |  0  
  Cleaned          |  0 |  0  

Total in 12[9](https://github.com/jmichelgarcia/docs-temp-2/actions/runs/5254100494/jobs/9492291541#step:7:10)3 ms

I can also successfully reproduce locally, by simply executing the below command several times

hugo --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development

docs-temp-2 git:(main) hugo --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development
Start building sites … 
hugo v0.113.0+extended darwin/arm64 BuildDate=unknown
WARN 2023/06/13 11:19:15 .File.UniqueID on zero object. Wrap it in if or with: {{ with .File }}{{ .UniqueID }}{{ end }}

                   | EN | FR  
-------------------+----+-----
  Pages            |  4 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  3 |  0  
  Sitemaps         |  0 |  0  
  Cleaned          |  0 |  0  

Total in 410 ms
➜  docs-temp-2 git:(main) hugo --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development
Start building sites … 
hugo v0.113.0+extended darwin/arm64 BuildDate=unknown
WARN 2023/06/13 11:19:17 .File.UniqueID on zero object. Wrap it in if or with: {{ with .File }}{{ .UniqueID }}{{ end }}

                   | EN | FR  
-------------------+----+-----
  Pages            |  4 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  3 |  0  
  Sitemaps         |  0 |  0  
  Cleaned          |  0 |  0  

Total in 389 ms
➜  docs-temp-2 git:(main) hugo --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development
Start building sites … 
hugo v0.113.0+extended darwin/arm64 BuildDate=unknown

                   | EN | FR  
-------------------+----+-----
  Pages            |  1 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  0 |  0  
  Sitemaps         |  1 |  0  
  Cleaned          |  0 |  0  

Total in 113 ms

My intuition is telling me that it could be related to my configs:

_default
- hugo.toml
production
- hugo.toml

When I delete production/hugo.toml, then I cannot reproduce this locally anymore. When I add it back, the build randomly glitches.

I just did some tests locally (tried to break it starting from 110, and from my tests this glitches was introduced as part of 112

hugo v0.112.0-0a95d6704a8ac8d41cc5ca8fffaad8c5c7a3754a+extended darwin/arm64 BuildDate=2023-05-23T08:14:20Z VendorInfo=gohugoio
➜  docs-temp-2 git:(main) ✗ npm run break-it                            

> docs@0.0.1 break-it
> hugo --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development --debug

Start building sites … 
hugo v0.112.0-0a95d6704a8ac8d41cc5ca8fffaad8c5c7a3754a+extended darwin/arm64 BuildDate=2023-05-23T08:14:20Z VendorInfo=gohugoio
INFO 2023/06/13 11:46:57 syncing static files to /
INFO 2023/06/13 11:46:57 process in 0 ms
INFO 2023/06/13 11:46:57 assemble in 0 ms
INFO 2023/06/13 11:46:57 render in 2 ms
INFO 2023/06/13 11:46:57 postProcess in 0 ms

                   | EN | FR  
-------------------+----+-----
  Pages            |  1 |  0  
  Paginator pages  |  0 |  0  
  Non-page files   |  0 |  0  
  Static files     | 33 | 33  
  Processed images |  0 |  0  
  Aliases          |  0 |  0  
  Sitemaps         |  1 |  0  
  Cleaned          |  0 |  0

bep · 2023-06-13T11:09:49Z

@jmichelgarcia OK, I can reproduce this too (but very rarely), thanks a lot, much appreciated.

bep · 2023-06-13T11:20:02Z

This bash script fails every time:

#!/bin/bash
for i in {1..100} 
do
    rm -rf public
    hugo --quiet --config hugo.toml --configDir config --disableKinds=taxonomy,term,rss,sitemap,robotsTXT --noBuildLock --noChmod --noTimes --watch=false --enableGitInfo=false -e development
    size=`tree public | wc -l`
    expect=57
    if [ $size -ne $expect ]
    then
        echo "[$i] Expected $expect lines, got $size"
        exit 1
    fi
done

bep · 2023-06-13T14:14:41Z

OK, the problems seem to be an ordering/merge issue with disableKinds (flag vs site config vs language config). Not sure exactly, but if you set these per language, things behaves:

[languages]
  [languages.en]
    disableKinds = ["taxonomy", "term", "rss", "sitemap", "robotsTXT"]
    title        = "Documentation"
    languageName = "English"
    languageCode = "en"
    staticDir    = "static"
    contentDir   = "content/en"
  [languages.fr]
    title = "Documentation"
    languageName = "French"
    languageCode = "fr"
    contentDir = "content/fr"
    staticDir = "static_fr"
    disableKinds = [
      "page",
      "home",
      "section",
      "taxonomy",
      "taxonomyTerm",
      "rss",
      "sitemap",
      "robotsTXT",
      "404",
    ]

Fixes gohugoio#11089 ~/d/g/g/hugo ❯❯❯ git resetf fix/myseryconfigissue-11089 ✭ ✱

Fixes #11089

jmichelgarcia · 2023-06-13T18:07:46Z

Thanks @bep. Really helpful.

github-actions · 2023-07-05T02:08:37Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

bep added Bug NeedsTriage NeedsInvestigation and removed NeedsTriage labels Jun 13, 2023

bep modified the milestones: v0.114.0, v0.113.0, v0.115.0 Jun 13, 2023

bep mentioned this issue Jun 13, 2023

Fix config merge regression with root slices (e.g. disableKinds) #11099

Merged

bep added a commit to bep/hugo that referenced this issue Jun 13, 2023

Fix config merge regression with root slices (e.g. disableKinds)

d79f6f1

Fixes gohugoio#11089 ~/d/g/g/hugo ❯❯❯ git resetf fix/myseryconfigissue-11089 ✭ ✱

bep removed the NeedsInvestigation label Jun 13, 2023

bep closed this as completed in #11099 Jun 13, 2023

bep added a commit that referenced this issue Jun 13, 2023

Fix config merge regression with root slices (e.g. disableKinds)

60a2cdf

Fixes #11089

github-actions bot added the Outdated label Jul 5, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check potential output format issue with output formats in hugo server on GitHub action #11089

Check potential output format issue with output formats in hugo server on GitHub action #11089

bep commented Jun 13, 2023

jmichelgarcia commented Jun 13, 2023 •

edited

Loading

bep commented Jun 13, 2023 •

edited

Loading

bep commented Jun 13, 2023

bep commented Jun 13, 2023 •

edited

Loading

jmichelgarcia commented Jun 13, 2023

github-actions bot commented Jul 5, 2023

Check potential output format issue with output formats in hugo server on GitHub action #11089

Check potential output format issue with output formats in hugo server on GitHub action #11089

Comments

bep commented Jun 13, 2023

jmichelgarcia commented Jun 13, 2023 • edited Loading

bep commented Jun 13, 2023 • edited Loading

bep commented Jun 13, 2023

bep commented Jun 13, 2023 • edited Loading

jmichelgarcia commented Jun 13, 2023

github-actions bot commented Jul 5, 2023

jmichelgarcia commented Jun 13, 2023 •

edited

Loading

bep commented Jun 13, 2023 •

edited

Loading

bep commented Jun 13, 2023 •

edited

Loading