jQuery minify issue with new hugo v0.113.0+extended

[tfsojon]

This issue with the latest release.

• Using Hugo (v0.113.0+extended)
• jquery-3.7.0.js

{{ $scripts := slice }}
{{ range site.Params.plugins.js}}
{{ $scripts = $scripts | append (resources.Get .link) }}
{{ end }}
{{ $scripts = $scripts | append (resources.Get "js/script.js") }}
{{ $scripts = $scripts | resources.Concat "/js/script.js" | minify | fingerprint "sha512" }}

without minify its working

{{ $scripts := slice }}
{{ range site.Params.plugins.js}}
{{ $scripts = $scripts | append (resources.Get .link) }}
{{ end }}
{{ $scripts = $scripts | append (resources.Get "js/script.js") }}
{{ $scripts = $scripts | resources.Concat "/js/script.js" | fingerprint "sha512" }}

[bep]

Do you any info about the last version of Hugo this was OK?

[bep]

Yes, this is a bug and needs to be fixed, but I think you would get a better JS setup if you rewrote the above to use

• https://gohugo.io/hugo-pipes/js/
• which supports imports directly from assets (e.g. your jquery)
• has an option for minification

[bep]

I just quickly tested this with that jQuery version and even minified it worked OK (I just ran some basic jquery examples found online) ... Which I guess it means that there's a certain part of jQuery that you use that somehow gets mingled. Which means that the upstream author probably needs some more info.

[tfsojon]

I'm setting up a theme and will link the repo to this issue.

[tfsojon]

@bep https://github.com/tfsojon/jquery-hugo

[bep]

Not that it makes any difference in this case (it fails also starting with the unminified jQuery source), but doing minification on already minified JS sources is not something I would recommend.

As to this issue, I'm reverting the upstream library to a working version for Hugo 0.114 (out soon).

[jmooring]

@tfsojon How do I reproduce the problem with the repo you linked to?

Disregard.

[jmooring]

While reducing this to a simple example, I found that the problem is exposed when the minified resource is rendered inline (see original code).

For example, this fails:

<script>{{ $js.Content | safeJS }}</script>

This does not fail:

<script src="{{ $js.RelPermalink }}"></script>

This may be an encoding issue, perhaps related to tdewolff/minify@9fbf910 or tdewolff/minify@7d47c2c.

Google Chrome and Firefox behave identically.

---

Minimal example:

git clone --single-branch -b hugo-github-issue-11132 https://github.com/jmooring/hugo-testing hugo-github-issue-11132
cd hugo-github-issue-11132

Open the browser's console, then:

hugo server --disableLiveReload

[jmooring]

I can confirm that was fixed with tdewolff/minify v2.12.7. Verified against @tfsojon's test repo, as well as the minimal example above. Tested with minified script inline and external.

[tfsojon]

Thank You. Issue Solved with v0.114.0

[bep]

v0.114.0 was a ... workaround.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.