Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

languages.xx.disabled not working with v0.112.0 and later #11219

Closed
jmooring opened this issue Jul 7, 2023 · 3 comments · Fixed by #11226
Closed

languages.xx.disabled not working with v0.112.0 and later #11219

jmooring opened this issue Jul 7, 2023 · 3 comments · Fixed by #11226
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.115.2

Comments

@jmooring
Copy link
Member

jmooring commented Jul 7, 2023

This works as expected with v0.111.3 and earlier:

[languages.es]
languageCode = 'es-ES'
weight = 3
disabled = true

With v0.112.0 and later, the site above is published (the disabled key is ignored) with this warning:

WARN config: languages.es.disabled: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.es.params].
@jmooring
Copy link
Member Author

jmooring commented Jul 7, 2023 •
edited

See #4963 (comment).

I don't think languages.xx.disabled was ever documented, so perhaps this behavior is correct (not a bug).

@bep bep removed the NeedsTriage label Jul 8, 2023
@bep bep added this to the v0.115.2 milestone Jul 8, 2023
@bep bep self-assigned this Jul 8, 2023
@bep
Copy link
Member

bep commented Jul 8, 2023 •
edited

Workaround: disableLanguages = ["en'] ... I don't find language.disabled in the docs, which is probably why it got lost ...

@bep bep mentioned this issue Jul 8, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Jul 8, 2023
@bep
Restore language.disabled config
24add3e 
Fixes gohugoio#11219
@bep bep closed this as completed in #11226 Jul 8, 2023
bep added a commit that referenced this issue Jul 8, 2023
@bep
Restore language.disabled config
a481942 
Fixes #11219
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.115.2
Development

Successfully merging a pull request may close this issue.

Restore language.disabled config bep/hugo
2 participants
@jmooring @bep