Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return integrity value as string #11513

Closed
jmooring opened this issue Sep 29, 2023 · 2 comments · Fixed by #11515
Closed

Return integrity value as string #11513

jmooring opened this issue Sep 29, 2023 · 2 comments · Fixed by #11515

Comments

@jmooring
Copy link
Member

This isn't broken, but it isn't right either. The template.HTMLAttr type is applicable to a key/value pair, not just the value.

func integrity(algo string, sum []byte) template.HTMLAttr {
encoded := base64.StdEncoding.EncodeToString(sum)
return template.HTMLAttr(algo + "-" + encoded)
}

Return a string instead.

@bep
Copy link
Member

bep commented Oct 2, 2023

Hmm... I was about to tell you that "this cannot be right", then I read the documentation.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants