-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periods in taxonomies generates bad paths #1188
Comments
Original bug finder here. I'm going to try to fix this. I don't know go: wish me luck... 😃 |
Good luck! The URL handling in Hugo is a little bit too fragmented, but there should be test cases (see site_test.go and page_test.go - esp. the first) that will break when you add some periods. |
Yes, I've discovered that the URL handling is rather complex and probably in need of streamlining. I'm thinking the most straightforward way to do this is having a new simpler method on https://github.com/spf13/hugo/blob/master/hugolib/site.go#L1384. This new method would only know how to turn the "/{taxonomy}/{key}" and "/{section}/{key}" formats into pretty and ugly urls. |
Yes, that sounds reasonable. |
It appears that the rss feeds don't respect the ulgyURLs flag. Is this a bug? |
No, that is by design. They even have the rssURI to make them as ugly as it gets. |
I'm still working on this, as I have time. It's a rather tricky issue. I'm having trouble finding a non-invasive fix that doesn't cause side effects. And now I'm a couple months behind HEAD. Anyway, just to let you know I'm not dead and that I'm still trying to fix this. I'd really like to upgrade from v0.12. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See
http://discuss.gohugo.io/t/periods-in-taxonomies-are-generating-bad-paths/1258
The text was updated successfully, but these errors were encountered: