Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periods in taxonomies generates bad paths #1188

Closed
bep opened this issue Jun 1, 2015 · 8 comments
Closed

Periods in taxonomies generates bad paths #1188

bep opened this issue Jun 1, 2015 · 8 comments
Milestone

Comments

@bep
Copy link
Member

bep commented Jun 1, 2015

See

http://discuss.gohugo.io/t/periods-in-taxonomies-are-generating-bad-paths/1258

@bep bep added the Bug label Jun 1, 2015
@bep bep self-assigned this Jun 1, 2015
@bep bep added this to the v0.15 milestone Jun 1, 2015
@bep bep removed their assignment Jun 1, 2015
@ryanclarke
Copy link
Contributor

Original bug finder here. I'm going to try to fix this. I don't know go: wish me luck... 😃

@bep
Copy link
Member Author

bep commented Jun 1, 2015

Good luck!

The URL handling in Hugo is a little bit too fragmented, but there should be test cases (see site_test.go and page_test.go - esp. the first) that will break when you add some periods.

@ryanclarke
Copy link
Contributor

Yes, I've discovered that the URL handling is rather complex and probably in need of streamlining.

I'm thinking the most straightforward way to do this is having a new simpler method on https://github.com/spf13/hugo/blob/master/hugolib/site.go#L1384. This new method would only know how to turn the "/{taxonomy}/{key}" and "/{section}/{key}" formats into pretty and ugly urls.

@bep
Copy link
Member Author

bep commented Jun 3, 2015

Yes, that sounds reasonable.

@ryanclarke
Copy link
Contributor

It appears that the rss feeds don't respect the ulgyURLs flag. Is this a bug?

@bep
Copy link
Member Author

bep commented Jun 4, 2015

No, that is by design. They even have the rssURI to make them as ugly as it gets.

@ryanclarke
Copy link
Contributor

I'm still working on this, as I have time. It's a rather tricky issue. I'm having trouble finding a non-invasive fix that doesn't cause side effects. And now I'm a couple months behind HEAD.

Anyway, just to let you know I'm not dead and that I'm still trying to fix this. I'd really like to upgrade from v0.12.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants