Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check (stable) sort order for duplicate resource names #11946

Closed
bep opened this issue Jan 30, 2024 · 2 comments · Fixed by #11950
Closed

Check (stable) sort order for duplicate resource names #11946

bep opened this issue Jan 30, 2024 · 2 comments · Fixed by #11950
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Jan 30, 2024

No description provided.

@bep bep added the Bug label Jan 30, 2024
@bep bep added this to the v0.123.0 milestone Jan 30, 2024
@bep bep self-assigned this Jan 30, 2024
@bep
Copy link
Member Author

bep commented Jan 30, 2024

/cc @jmooring this is re your "now it works, now it doesn't" but; we should at least get the sort order stable, so I will check this tomorrow.

bep added a commit that referenced this issue Jan 31, 2024
We do a slight normalisation of the content paths (lower case, replacing " " with "-") and remove andy language identifier before inserting them into the content tree.

This means that, given that that the default content language is `en`:

```
index.md
index.html
Foo Bar.txt
foo-bar.txt
foo-bar.en.txt
Foo-Bar.txt
```

The bundle above will be reduced to one content file with one resource (`foo-bar.txt`).

Before this commit, what version of the `foo-bar.txt` you ended up with was undeterministic. No  we pick the first determined by sort order.

Note that the sort order is stable, but we recommend avoiding situations like the above.

Closes #11946
bep added a commit that referenced this issue Jan 31, 2024
We do a slight normalisation of the content paths (lower case, replacing " " with "-") and remove andy language identifier before inserting them into the content tree.

This means that, given that that the default content language is `en`:

```
index.md
index.html
Foo Bar.txt
foo-bar.txt
foo-bar.en.txt
Foo-Bar.txt
```

The bundle above will be reduced to one content file with one resource (`foo-bar.txt`).

Before this commit, what version of the `foo-bar.txt` you ended up with was undeterministic. No  we pick the first determined by sort order.

Note that the sort order is stable, but we recommend avoiding situations like the above.

Closes #11946
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant