Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Web Server is available at ..." on rebuilds needs to come after any log statements (before Total ...) #12384

Closed
bep opened this issue Apr 17, 2024 · 4 comments

Comments

@bep
Copy link
Member

bep commented Apr 17, 2024

Also

  • make sure it's not printed on hugo -w.
  • print it for all rebuilds, including config changes
@bep bep added the Bug label Apr 17, 2024
@bep bep added this to the v0.125.1 milestone Apr 17, 2024
@bep bep added Enhancement and removed Bug labels Apr 17, 2024
@bep bep modified the milestones: v0.125.1, v0.125.2 Apr 18, 2024
@jmooring
Copy link
Member

Yeah, I saw this when testing #12367 but didn't worry about it since log statements continue after the "Total" display anyway. I briefly looked at this yesterday, and couldn't figure out an expedient way to handle it.

@bep
Copy link
Member Author

bep commented Apr 19, 2024

log statements continue after the "Total" display

I'm pretty sure "Total in ..." is the last entry for a given build. In normal scenarios it is the last entry. I understand that our writing to stdout isn't synchronised or anything, but as it is now, it looks ... messy when running with --logLevel info.

@jmooring
Copy link
Member

With multilingual sites I see:

INFO  build:  step render substep pages site en outputFormat html duration 3.509292ms
INFO  build:  step render substep pages site en outputFormat rss duration 1.989274ms
INFO  build:  step render substep pages site de outputFormat html duration 510.836µs
INFO  build:  step render substep pages site de outputFormat rss duration 554.714µs
INFO  build:  step render pages 5 content 2 duration 9.811543ms
INFO  build:  step postProcess duration 65.566µs
INFO  build:  duration 28.630744ms
Total in 29 ms
INFO  build:  step render substep pages site en outputFormat html duration 563.61µs
INFO  build:  step render substep pages site en outputFormat rss duration 466.159µs
INFO  build:  step render substep pages site de outputFormat html duration 552.515µs
INFO  build:  step render substep pages site de outputFormat rss duration 337.426µs
INFO  build:  step render pages 0 content 0 duration 3.2983ms
INFO  build:  step postProcess duration 52.173µs
INFO  build:  duration 3.936471ms

bep added a commit to bep/hugo that referenced this issue Apr 20, 2024
@bep bep modified the milestones: v0.125.2, v0.125.3, v0.125.4 Apr 22, 2024
@bep bep modified the milestones: v0.125.4, v0.125.6 May 1, 2024
bep added a commit to bep/hugo that referenced this issue May 1, 2024
Also fix it so

* It's not printed when running `hugo -w`
* It'd printed for all kinds of rebuilds

Fixes gohugoio#12384
@bep bep closed this as completed in c8e400b May 1, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants