Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascade deletion of title and similar not handled very well on partial rebuilds #12449

Closed
bep opened this issue May 1, 2024 · 1 comment · Fixed by #12452
Closed

Cascade deletion of title and similar not handled very well on partial rebuilds #12449

bep opened this issue May 1, 2024 · 1 comment · Fixed by #12452
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.125.5

Comments

@bep
Copy link
Member

bep commented May 1, 2024

I noticed this when looking into #12436.

  • In Page does not reload after modifying a different page #12436 I noticed that we do a little too much work when a _index.md changes; we also re-reads all the bundles in that folder, which should not be needed.
  • When adjusting that logic, I get a test failure from some cascade edits that I would say accidently passed because of the above.
@bep bep self-assigned this May 1, 2024
@bep bep removed the NeedsTriage label May 1, 2024
@bep bep added this to the v0.125.5 milestone May 1, 2024
@bep bep changed the title Issue with rebuilding on change in cascade Deletion of cascade attributes not handled very well on partial rebuilds May 1, 2024
@bep bep changed the title Deletion of cascade attributes not handled very well on partial rebuilds Cascade edits of title and similar not handled very well on partial rebuilds May 1, 2024
@bep bep changed the title Cascade edits of title and similar not handled very well on partial rebuilds Cascade deletion of title and similar not handled very well on partial rebuilds May 1, 2024
bep added a commit to bep/hugo that referenced this issue May 1, 2024
@bep
Fix rebuilds on cascade deletes/renames
17db3d9 
And also avoid reading sub directories on simple changes to branch `_index.md` files.

Fixes gohugoio#12449
@bep bep mentioned this issue May 1, 2024
Merged
bep added a commit that referenced this issue May 1, 2024
@bep
Fix rebuilds on cascade deletes/renames
7be7f89 
And also avoid reading sub directories on simple changes to branch `_index.md` files.

Fixes #12449
@bep bep closed this as completed in #12452 May 1, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.125.5
Development

Successfully merging a pull request may close this issue.

Fix rebuilds on cascade deletes/renames bep/hugo
1 participant
@bep