Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create/skeletons: Remove superfluous language code fallback #12479

Closed
jmooring opened this issue May 10, 2024 · 1 comment · Fixed by #12483
Closed

create/skeletons: Remove superfluous language code fallback #12479

jmooring opened this issue May 10, 2024 · 1 comment · Fixed by #12483
Labels
Enhancement Feature: Embedded Template Outdated
Milestone
v0.126.0

Comments

@jmooring
Copy link
Member

hugo/create/skeletons/theme/layouts/_default/baseof.html

Line 2 in b1bf0bf

<html lang="{{ or site.Language.LanguageCode site.Language.Lang }}" dir="{{ or site.Language.LanguageDirection `ltr` }}">

With v0.112.0 and later, site.Language.LanguageCode falls back to site.Language.Lang, so the explicit fallback above is not required.
@jmooring jmooring mentioned this issue May 10, 2024
Closed
@bep bep added this to the v0.126.0 milestone May 10, 2024
jmooring added a commit to jmooring/hugo that referenced this issue May 10, 2024
@jmooring
create/skeletons: Remove superfluous language code fallback
50d129a 
Closes gohugoio#12479
@jmooring jmooring mentioned this issue May 10, 2024
Merged
bep pushed a commit that referenced this issue May 14, 2024
@jmooring @bep
create/skeletons: Remove superfluous language code fallback
55dea41 
Closes #12479
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Feature: Embedded Template Outdated
Projects
None yet
Milestone
v0.126.0
Development

Successfully merging a pull request may close this issue.

create/skeletons: Remove superfluous language code fallback jmooring/hugo
2 participants
@jmooring @bep