Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate GetTerms performance #12610

Closed
bep opened this issue Jun 19, 2024 · 0 comments · Fixed by #12611
Closed

Investigate GetTerms performance #12610

bep opened this issue Jun 19, 2024 · 0 comments · Fixed by #12611
Assignees
@bep
Labels
Bug
Milestone
v0.128.0

Comments

@bep
Copy link
Member

bep commented Jun 19, 2024

See https://discourse.gohugo.io/t/getterms-getting-slows-as-the-content-grows/50332
@bep bep self-assigned this Jun 19, 2024
@bep bep removed the NeedsTriage label Jun 19, 2024
@bep bep added this to the v0.128.0 milestone Jun 19, 2024
bep added a commit to bep/hugo that referenced this issue Jun 19, 2024
@bep
Speed up GetTerms
4ecdf56 
```text
name                               old time/op    new time/op    delta
TaxonomiesGetTerms/pages_100-10      5.25ms  5%    5.13ms  4%     ~     (p=0.486 n=4+4)
TaxonomiesGetTerms/pages_1000-10     30.1ms  1%    26.8ms  1%  -11.13%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_10000-10     1.33s 24%     0.29s  2%  -78.42%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_20000-10     5.50s 12%     0.83s 28%  -84.88%  (p=0.029 n=4+4)

name                               old alloc/op   new alloc/op   delta
TaxonomiesGetTerms/pages_100-10      4.08MB  0%    4.06MB  0%   -0.59%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_1000-10     25.1MB  0%    24.9MB  0%   -0.87%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_10000-10     238MB  2%     233MB  0%   -1.94%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_20000-10     469MB  0%     465MB  0%   -1.00%  (p=0.029 n=4+4)

name                               old allocs/op  new allocs/op  delta
TaxonomiesGetTerms/pages_100-10       49.5k  0%     48.9k  0%   -1.17%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_1000-10       304k  0%      298k  0%   -1.97%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_10000-10     3.02M  7%     2.81M  0%   -7.09%  (p=0.029 n=4+4)
TaxonomiesGetTerms/pages_20000-10     5.77M  1%     5.59M  0%   -3.19%  (p=0.029 n=4+4)

```

Note that the numbers above represents a full site build, but GetTerms is a big part of the site in question.

Fixes gohugoio#12610
@bep bep mentioned this issue Jun 19, 2024
Merged
@bep bep closed this as completed in 478a910 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bep bep

Labels
Bug
Projects
None yet
Milestone
v0.128.0
Development

Successfully merging a pull request may close this issue.

Speed up GetTerms bep/hugo
1 participant
@bep