Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement the browser livereload logic #12643

Closed
bep opened this issue Jul 6, 2024 · 1 comment · Fixed by #12647
Closed

Reimplement the browser livereload logic #12643

bep opened this issue Jul 6, 2024 · 1 comment · Fixed by #12647
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.129.0

Comments

@bep
Copy link
Member

bep commented Jul 6, 2024

The logic in the commands package that does browser refreshes/navigation, is hard to follow, and I see one assumption that's not obviously right: That CSS changes only gets triggered by assets changes.

This has been working mostly great, but the logic here can be made simpler and more robust.
@bep bep added the Bug label Jul 6, 2024
@bep bep added this to the v0.129.0 milestone Jul 6, 2024
@bep bep self-assigned this Jul 6, 2024
@bep bep mentioned this issue Jul 6, 2024
Merged
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
Use xxHash for the change detector
f282f80 
Much faster compared to MD5:

```
name          old time/op    new time/op    delta
HashingFs-10    21.3s  2%     3.2s 17%  -84.96%  (p=0.029 n=4+4)

name          old alloc/op   new alloc/op   delta
HashingFs-10    12.9kB  0%    12.8kB  1%   -1.31%  (p=0.029 n=4+4)

name          old allocs/op  new allocs/op  delta
HashingFs-10      10.0  0%       7.0  0%  -30.00%  (p=0.029 n=4+4)
```

Updates gohugoio#12643
@bep bep mentioned this issue Jul 6, 2024
Closed
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
Use xxHash for the change detector
ea2d4f5 
Much faster compared to MD5:

```
name          old time/op    new time/op    delta
HashingFs-10    21.3µs ± 2%     3.2µs ±17%  -84.96%  (p=0.029 n=4+4)

name          old alloc/op   new alloc/op   delta
HashingFs-10    12.9kB ± 0%    12.8kB ± 1%   -1.31%  (p=0.029 n=4+4)

name          old allocs/op  new allocs/op  delta
HashingFs-10      10.0 ± 0%       7.0 ± 0%  -30.00%  (p=0.029 n=4+4)
```

Updates gohugoio#12643
bep added a commit that referenced this issue Jul 6, 2024
@bep
Use xxHash for the change detector
fb8909d 
Much faster compared to MD5:

```
name          old time/op    new time/op    delta
HashingFs-10    21.3µs ± 2%     3.2µs ±17%  -84.96%  (p=0.029 n=4+4)

name          old alloc/op   new alloc/op   delta
HashingFs-10    12.9kB ± 0%    12.8kB ± 1%   -1.31%  (p=0.029 n=4+4)

name          old allocs/op  new allocs/op  delta
HashingFs-10      10.0 ± 0%       7.0 ± 0%  -30.00%  (p=0.029 n=4+4)
```

Updates #12643
@bep bep mentioned this issue Jul 6, 2024
Closed
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
commands: Simplify the browser live reload logic
34b35c9 
And improve the logging for live reload.

Closes gohugoio#12643
@bep bep mentioned this issue Jul 6, 2024
Merged
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
commands: Simplify the browser live reload logic
8c8a256 
And improve the logging for live reload.

Closes gohugoio#12643
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
commands: Simplify the browser live reload logic
f4f9a95 
And improve the logging for live reload.

Closes gohugoio#12643
bep added a commit to bep/hugo that referenced this issue Jul 6, 2024
@bep
commands: Simplify the browser live reload logic
6a56d6f 
And improve the logging for live reload.

Closes gohugoio#12643
bep added a commit to bep/hugo that referenced this issue Jul 7, 2024
@bep
commands: Simplify the browser live reload logic
13c63a1 
And improve the logging for live reload.

Closes gohugoio#12643
@bep bep closed this as completed in #12647 Jul 7, 2024
bep added a commit that referenced this issue Jul 7, 2024
@bep
commands: Simplify the browser live reload logic
094f746 
And improve the logging for live reload.

Closes #12643
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.129.0
Development

Successfully merging a pull request may close this issue.

commands: Simplify the browser live reload logic bep/hugo
1 participant
@bep