Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalink on Node and Page should be of same type #1384

Closed
Jos512 opened this issue Aug 29, 2015 · 1 comment
Closed

Permalink on Node and Page should be of same type #1384

Jos512 opened this issue Aug 29, 2015 · 1 comment
Labels
Bug Outdated

Comments

@Jos512
Copy link

Jos512 commented Aug 29, 2015

Hello,

The .Permalink variable for pages and nodes returns the permanent link for the current webpage, but the .Permalink on pages is of type string while the same variable on nodes is of type template.HTML.

So when I have the following code in my default_head.html:

Page/Node permalink: {{ .Permalink }}
{{ if in .Permalink "categoryname" }}
    This is a match
{{ end }}

On my section page it prints:

Page/Node permalink: http://localhost:1313/categoryname/

On posts belonging to that section it prints:

Page/Node permalink: http://localhost:1313/categoryname/post-name/ This is a match

If it's not possible/feasible to change the behaviour of .Permalink on pages and nodes, perhaps a .URL variable can be added to pages? Then both a page and a node can have a string type variable (.URL) that returns the webpage's URLs (excluding the base URL).

(This issue is made after a discussion here: Permalink node pages - if in issue.)
@bep bep added the Bug label Aug 29, 2015
@bep bep changed the title Permalink issue on node pages Permalink on Node and Page should be of same type Aug 29, 2015
kzys added a commit to kzys/hugo that referenced this issue Oct 17, 2015
@kzys
Permalink on Node and Page should be of string
f6a05b2 
This change fixes gohugoio#1384.
@kzys kzys mentioned this issue Oct 17, 2015
Closed
@bep bep closed this as completed in 99acbb2 Nov 23, 2015
bramp pushed a commit to bramp/hugo that referenced this issue Dec 17, 2015
@kzys @bramp
Permalink on Node and Page should be of string
93624de 
This change fixes gohugoio#1384.
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@kzys @tychoish
Permalink on Node and Page should be of string
e5fe90f 
This change fixes gohugoio#1384.
bep added a commit that referenced this issue Apr 20, 2021
@bep
Squashed 'docs/' changes from 9cece6640..fb551cc75
07b8d94 
fb551cc75 Update index.md
7af894857 Update index.md
d235753ea Hugo 0.82.1
e03e72deb Merge branch 'temp0821'
e62648961 Merge branch 'release-0.82.1'
e1ab0f6eb releaser: Add release notes to /docs for release of 0.82.1
5d354c38d Replaced ``` code blocks with Code Toggler
c9d065c20 Remove duplicate YAML keys (#1420)
8ae31e701 Add webp image encoding support
848f2af26 Update internal.md (#1407)
c103a86a4 Fix `ref` shortcode example output (#1409)
9f8ba56dc Remove leading dot from where function KEY (#1419)
363251a51 Improve presentation of template lookup order (#1382)
b73da986d Improve description of Page Resources (#1381)
4e0bb96d5 Rework robots.txt page (#1405)
edf893e6f Update migrations.md (#1412)
450f1580b Add link to `site` function doc (#1417)
cfffa6e6f Added one extension to the list (#1414)
05f1665a0 Update theme
5de0b1c6a Update theme
250e20552 Add hugo.IsExtended
dea5e1fd7 Fix typo on merge function page (#1408)
1bbed2cf3 Update configuration.md
be0b64a46 Omit ISO
cbb5b8367 Fix `dateFormat` documentation
698f15466 Regenerate the docshelper
f9a8a7cb6 Update multilingual.md
a22dc6267 Fix grammar (#1398)
eb98b0997 Fix pretty URL example (#1397)
f4c4153dc Mention date var complementation in post scheduling (#1396)
17fae284c Fix resources.ExecuteAsTemplate argument order (#1394)
97e2c2abb Use code-toggle shortcode in `multilingual.md` (#1388)
3a84929bb Harmonize capitalization (#1393)
17f15daa6 fix file naming used in example (#1392)
5d97b6a18 Add slice syntax to sections permalinks config
00665b97b Improve description of `site.md`
edcf5e3fc Fix example in `merge.md`
f275ab778 Update postprocess.md
9593e3991 Fix file name
59bd9656f Update postprocess.md
1172fb6d0 Update to theNewDynamic repository (#1263)
f5b5c1d2c Update Hugo container image
4f2e92f2a Adapt anchorize.md to Goldmark
98aa19073 Directly link to `highlight` shortcode (#1384)
4c75c2422 Fix header level
f15c06f23 markdownify: add note about render-hooks and .RenderString (#1281)
69c82eb68 Remove Blackfriday reference from shortcode desc (#1380)
36de478df Update description of ignoreFiles config setting (#1377)
6337699d8 Remove "Authors" page from documentation (#1371)
35e73ca90 fix indent in example (#1372)
d3f01f19a Remove opening body tag from header example (#1376)
341a5a7d8 Update index.md
c9bfdbee6 Release 0.82.0
119644949 releaser: Add release notes to /docs for release of 0.82.0
32efaed78 docs: Regenerate docs helper
dea5449a2 docs: Regen CLI docs
eeab18fce Merge commit '81689af79901f0cdaff765cda6322dd4a9a7ccb3'
d508a1259 Attributes for code fences should be placed after the lang indicator only
c80905cef deps: Update to esbuild v0.9.0
95350eb79 Add support for Google Analytics v4
02d36f9bc Allow markdown attribute lists to be used in title render hooks
7df220a64 Merge commit '9d31f650da964a52f05fc27b7fb99cf3e09778cf'
d80bf61b7 Fixes #7698.

git-subtree-dir: docs
git-subtree-split: fb551cc750faa83a1493b0e0d0898cd98ab74465
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Permalink on Node and Page should be of string kzys/hugo
2 participants
@bep @Jos512