Make chomp return the type it receives

[bep]

See https://discuss.gohugo.io/t/errors-with-type-template-html-should-be-string-with-hugo-0-16-0/3470/3

[bep]

See golang/go#15974

[bep]

This issue has been automatically marked as stale because it has not been commented on for at least four months.

The resources of the Hugo team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still valuable, please open a proposal at https://discuss.gohugo.io/.

This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

[bep]

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.

If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

[moorereason]

The core issue remains: chomp returns a template.HTML type which index doesn't support as an index.

We've forked the index function from stdlib. We ought to be able to fix this ourselves.

[bep]

@moorereason what is the proper fix for this?

1. Make chomp return a string?
2. Make index support HTML?

[moorereason]

@bep,
chomp could return template.HTML if that's the type you sent it or return a string, otherwise.

Regardless of what I said in March, I don't think there's much need for index to support template.HTML.

[bep]

chomp could return template.HTML if that's the type you sent it or return a string, otherwise.

Yes, that sounds about right.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.